Mike Percy has posted comments on this change. Change subject: KUDU-1785. Fix potential crash in TabletCopySourceSession ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5363/6/src/kudu/integration-tests/tablet_copy_client_session-itest.cc File src/kudu/integration-tests/tablet_copy_client_session-itest.cc: Line 113: vector<scoped_refptr<Thread>> threads; > Nit: for testing, std::thread is more concise, because you don't need to sp Thanks for the tip, will keep that in mind for next time. -- To view, visit http://gerrit.cloudera.org:8080/5363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f3ec35885dbf1a81c23ac10b1c9556dfddbd4b7 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
