Alexey Serbin has posted comments on this change. Change subject: [i-tests] separated implementation of the ext mini-cluster ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5367/2//COMMIT_MSG Commit Message: Line 7: [i-tests] separated implementation of the ext mini-cluster > nit: I think a better commit message would be something like Done Line 14: warning: function 'StopCluster' defined in a header file; function > nit: Are you sure about this? I don't see any functions in here, only class Yep: check https://gerrit.cloudera.org/#/c/5345/5/src/kudu/integration-tests/external_mini_cluster-itest-base.h It might be false positive from clang-tidy, but even if that, having less include-dependencies would be better. -- To view, visit http://gerrit.cloudera.org:8080/5367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
