Mike Percy has submitted this change and it was merged.
Change subject: [ExternalMiniClusterITestBase] move some methods into .cc
......................................................................
[ExternalMiniClusterITestBase] move some methods into .cc
Separated implementation of the external mini-cluster methods into a
separate .cc file: those methods contain too much code to be candidates
for inlining. Besides, this helps to have less header-wise dependencies
and avoid clang-tidy warnings like
warning: function 'StopCluster' defined in a header file; function
definitions in header files can lead to ODR violations
[misc-definitions-in-headers]
This patch does not contain any functional changes.
Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
Reviewed-on: http://gerrit.cloudera.org:8080/5367
Reviewed-by: Mike Percy <[email protected]>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/delete_table-test.cc
A src/kudu/integration-tests/external_mini_cluster-itest-base.cc
M src/kudu/integration-tests/external_mini_cluster-itest-base.h
M src/kudu/integration-tests/tablet_replacement-itest.cc
7 files changed, 111 insertions(+), 54 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
