Mike Percy has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/5045/6/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS6, Line 62: 10 > Was this number picked considering a balanced (not overloaded) node may not Todd made the case, which I thought made sense, that there was no obvious answer so an arbitrary choice was better than a heuristic. So I just picked 10. I think you probably want at least 5 or 6, even if you don't have that many CPUs. We'll probably end up changing the default again later if it seems like this wasn't a great choice. Line 412: #define CALLBACK_AND_RETURN(status) \ > Yeah, my concern was a) it obligates the caller to follow inflexible naming Yeah, it's only used right here as syntactic sugar. PS6, Line 824: Cancel all outstanding tablet copy tasks > Am I correct in understanding that current code will wait till all in-progr Yeah, canceling would basically tombstone in-progress tablet copies and allow the thread pool to shut down immediately. -- To view, visit http://gerrit.cloudera.org:8080/5045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95c63f2bfd67624844447862efbdba9cb3676112 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
