Dinesh Bhat has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async ......................................................................
Patch Set 6: (3 comments) LGTM, couple of nits. http://gerrit.cloudera.org:8080/#/c/5045/6/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS6, Line 62: 10 Was this number picked considering a balanced (not overloaded) node may not have more than 20-30 tablets ? Why not use NumCPUS() instead ? Line 412: #define CALLBACK_AND_RETURN(status) \ > If we do that, we also need to include cb too. I just thought it looked mes Yeah, my concern was a) it obligates the caller to follow inflexible naming conventions and also its non-intuitive b) this leaves the programmer making mistakes like not setting the error_code before this macro (well, that room exists even when we include it as macro arg). If this MACRO isn't used outside of this context, I don't feel strongly about changing it. PS6, Line 824: Cancel all outstanding tablet copy tasks Am I correct in understanding that current code will wait till all in-progress copy threads complete vs the cancelling will pre-empt those threads and help with eagerly cleanups ? -- To view, visit http://gerrit.cloudera.org:8080/5045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95c63f2bfd67624844447862efbdba9cb3676112 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
