Mike Percy has posted comments on this change. Change subject: KUDU-1624. Fix data race in Trace::MetricsToJSON ......................................................................
Patch Set 1: Code-Review+2 nit: Would be nice to note that child_traces_ is protected by lock_ in the header file. -- To view, visit http://gerrit.cloudera.org:8080/5419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If72ccf3fc8e0d727f2c40b978889597e89ad891a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: No
