Adar Dembo has posted comments on this change. Change subject: KUDU-1624. Fix data race in Trace::MetricsToJSON ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5419/1/src/kudu/util/trace.cc File src/kudu/util/trace.cc: Line 231: e.second->MetricsToJSON(jw); We'll be making local copies of child_traces as we recurse, protected by the lock of course. Is it OK that the entirety of the MetricsToJSON() call operates on this somewhat inconsistent view of the trace tree? That is, new child traces may be added during the recursion; that doesn't make the JSON output invalid, does it? -- To view, visit http://gerrit.cloudera.org:8080/5419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If72ccf3fc8e0d727f2c40b978889597e89ad891a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
