Will Berkeley has posted comments on this change. Change subject: [spark] KUDU-1641 Pushdown SparkSQL In predicates ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5425/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: Line 208: assert(values.nonEmpty, "in list array must be nonempty") > Do we need to check this? Kudu should do the right thing and return an emp No longer applicable. See below. Line 209: values match { > I think this block will be cleaner if you do the `values.map` part inside t Actually the entire match block is unnecessary. The function can just create the in list predicate immediately. -- To view, visit http://gerrit.cloudera.org:8080/5425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia76dcbc0b5c5dcb2d28b468d8ed305b9f8eb8b28 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
