Todd Lipcon has posted comments on this change.

Change subject: [spark] KUDU-1641 Pushdown SparkSQL In predicates
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5425/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
File 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala:

Line 213:     
KuduPredicate.newInListPredicate(table.getSchema.getColumn(column), 
values.toList.asJava)
does Spark have any limit on the max number of elements in the IN list? do we? 
probably a good idea to put in some kind of limit here beyond which we don't 
try to push?


-- 
To view, visit http://gerrit.cloudera.org:8080/5425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76dcbc0b5c5dcb2d28b468d8ed305b9f8eb8b28
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-HasComments: Yes

Reply via email to