Alexey Serbin has posted comments on this change. Change subject: env: do not convert all Flush() calls into fsync() on macOS ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5457/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: PS1, Line 653: flags |= SYNC_FILE_RANGE_WAIT_AFTER I'm not quite familiar with intent of this method, but after looking into the non-linux section, reading docs for the method and http://man7.org/linux/man-pages/man2/sync_file_range.2.html (section 'Some details'), I think SYNC_FILE_RANGE_WAIT_BEFORE might be added into the flags as well to mirror fsync() behavior for range of the file data. In other words, I have a question: is SYNC_FILE_RANGE_WAIT_BEFORE flag omitted deliberately in case of FLUSH_SYNC mode? -- To view, visit http://gerrit.cloudera.org:8080/5457 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01bdd8dbaaad0205c0795a87dd973c8bf0fb87dc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
