Adar Dembo has posted comments on this change. Change subject: env: do not convert all Flush() calls into fsync() on macOS ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5457/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: PS1, Line 653: flags |= SYNC_FILE_RANGE_WAIT_AFTER > I'm not quite familiar with intent of this method, but after looking into t Hmm. It's largely academic since FLUSH_SYNC is never used (nor will it be, I think), but I suppose WAIT_BEFORE should be added. It's unclear to me, because I think WRITE | WAIT_AFTER could be interpreted as "write out all dirty pages and wait for all outstanding writes to finish", regardless of whether WAIT_BEFORE is added. But, it doesn't hurt. -- To view, visit http://gerrit.cloudera.org:8080/5457 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01bdd8dbaaad0205c0795a87dd973c8bf0fb87dc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
