Todd Lipcon has posted comments on this change. Change subject: KUDU-1801: catalog_manager: change TableInfo lock to a rwlock ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5471/1//COMMIT_MSG Commit Message: Line 55: "max": 364560, > Any idea why the max was higher "after"? nah, I figure max is typically due to a single outlier and not interesting. If there's any kind of real issue, the 99.99% latency would probably capture it, given we have 1.2M data points here http://gerrit.cloudera.org:8080/#/c/5471/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 3939: std::lock_guard<rw_spinlock> l(lock_); > Maybe this one could be a shared_lock? probably, yea -- To view, visit http://gerrit.cloudera.org:8080/5471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id77edbf7641275b54010514379cdfff228b408b5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
