Alexey Serbin has posted comments on this change. Change subject: KUDU-1767. c++ client: Prevent concurrent flushes by default ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5533/2/src/kudu/client/session-internal.cc File src/kudu/client/session-internal.cc: PS2, Line 82: condition_.Signal(); I think the mutex_ should be held while signalling on the condition, otherwise those events might be missed by the thread waiting on that condition variable. -- To view, visit http://gerrit.cloudera.org:8080/5533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e48a054093163824573962963ddcba122a948b8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
