Adar Dembo has posted comments on this change. Change subject: KUDU-1767. c++ client: Prevent concurrent flushes by default ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5533/2/src/kudu/client/session-internal.cc File src/kudu/client/session-internal.cc: PS2, Line 82: condition_.Signal(); > Thx for the review Alexey. I don't see any way for events to be missed by t I haven't reviewed the code but I wanted to add two points about this: 1. Almost all (but not all) of our ConditionVariable-using code holds the mutex during a Signal() or Broadcast(). 2. While ConditionVariable is implemented with pthreads today, this could change in the future. There's nothing pthread-specific about the interface, so we shouldn't poke a hole in the abstraction by relying on any pthread-only semantics, in case the underlying implementation changes, or in case Kudu is ported to a platform without pthreads (e.g. Windows). I don't know if that's the case here; I just wanted to bring up the point. -- To view, visit http://gerrit.cloudera.org:8080/5533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e48a054093163824573962963ddcba122a948b8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
