Todd Lipcon has posted comments on this change. Change subject: KUDU-699. consensus: Peer::Close() should not block on outstanding requests ......................................................................
Patch Set 3: (1 comment) OK, I looped the raft itest 1000 times in ASAN and consensus_peers-test 500 times in TSAN and the only failures are due to other unrelated known issues. So, I think this is good to go. Will rebase and submit (with Mike's nit fixed) http://gerrit.cloudera.org:8080/#/c/5490/3/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 245: lock.unlock(); > nit: no need to explicitly unlock before return Done -- To view, visit http://gerrit.cloudera.org:8080/5490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e1bc80f536defad28f4d7b51fb95aa32dc9fca0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
