Todd Lipcon has posted comments on this change. Change subject: threadpool: avoid calling task destructors while holding lock ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5517/1/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: Line 171: unique_lock.Unlock(); > Not a big deal, but why not use an RAII end-of-scope to destroy/unlock this considered it, but decided not to since then I would have had to move the 'to_release' definition outside of that scope, yielding more lines of code and not being able to use 'auto' -- To view, visit http://gerrit.cloudera.org:8080/5517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cdc38c7db0a6a7fd640d82895ecaebe0718ee98 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
