Alexey Serbin has posted comments on this change. Change subject: KUDU-1812: redact sensitive partition keys from logs ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5548/1/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: PS1, Line 668: return Substitute("GetTableLocations { table: '$0', attempt: $1 }", : table_->name(), num_attempts()); Is it ok to drop additional info here even if 'log_row_contents' is set to 'true'? http://gerrit.cloudera.org:8080/#/c/5548/1/src/kudu/common/partition.cc File src/kudu/common/partition.cc: PS1, Line 685: RangeKeyDebugString(key, schema) An extra parameter -- should be dropped. http://gerrit.cloudera.org:8080/#/c/5548/1/src/kudu/util/logging.cc File src/kudu/util/logging.cc: PS1, Line 66: log and error nit: may be just 'log messages'? I'm not sure how to differentiate between those. -- To view, visit http://gerrit.cloudera.org:8080/5548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eba5290145048d77d551b989865c05d928a9b10 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
