Todd Lipcon has posted comments on this change. Change subject: KUDU-1812: redact sensitive partition keys from logs ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5548/2/src/kudu/common/partition.cc File src/kudu/common/partition.cc: Line 626: components.emplace_back(Substitute("HASH ($0): $1", column_names, bucket)); I don't think the bucket number should be considered sensitive. Typical number of buckets are small enough that "hash(sensitive info) % n" is anonymized enough to not be worrisome IMO. To put my money where my mouth is, hash(my SSN) % 1024 is 880. http://gerrit.cloudera.org:8080/#/c/5548/2/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: Line 421: return kRedactionMessage; maybe we should at least indicate the number of ranges? add a TODO? -- To view, visit http://gerrit.cloudera.org:8080/5548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eba5290145048d77d551b989865c05d928a9b10 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
