Alexey Serbin has posted comments on this change. Change subject: WIP: Kudu Jepsen Tests - Initial Commit ......................................................................
Patch Set 4: (1 comment) Thank you for the review! I'll address most of your comments in my follow-up patch, since it would be too cumbersome updating this one and then merge those changes resolving multiple conflicts (my changes are based on top of this change). Basically, I'd address changes regarding building code with this patch and other things which do not bring too much conflicts. Would it be OK? http://gerrit.cloudera.org:8080/#/c/5492/4/java/kudu-jepsen/src/main/clojure/jepsen/kudu/table.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu/table.clj: Line 40: (defn kv-table-options > Any reason not to use hash partitioning? Would make this a lot easier, and Good point. I don't think there any particular reason for not using hash partitioning. I think we can make it an option and exercise both. But by default it should be hash partitioning, I think. I'll make that change in the follow-up patch. -- To view, visit http://gerrit.cloudera.org:8080/5492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I590c6e78840304b3131666c7037ff9a08dc77dea Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
