Alexey Serbin has posted comments on this change. Change subject: WIP: Kudu Jepsen Tests - Initial Commit ......................................................................
Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/5492/1/java/kudu-jepsen/.gitignore File java/kudu-jepsen/.gitignore: Line 1: /target > I think this shouldn't be necessary since the java/.gitignore contains targ Done http://gerrit.cloudera.org:8080/#/c/5492/1/java/kudu-jepsen/CHANGELOG.md File java/kudu-jepsen/CHANGELOG.md: Line 1: # Change Log > can probably be removed? Done http://gerrit.cloudera.org:8080/#/c/5492/1/java/kudu-jepsen/LICENSE File java/kudu-jepsen/LICENSE: Line 1: THE ACCOMPANYING PROGRAM IS PROVIDED UNDER THE TERMS OF THIS ECLIPSE PUBLIC > Remove Done http://gerrit.cloudera.org:8080/#/c/5492/1/java/kudu-jepsen/doc/intro.md File java/kudu-jepsen/doc/intro.md: Line 1: # Introduction to jepsen.kudu > remove Done http://gerrit.cloudera.org:8080/#/c/5492/1/java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj: Line 17: ;; TODO allow to replace the binaries with locally built ones > Yah, we should try and use the built in MiniCluster here, if possible. Wou That would be great to be able to use MiniCluster for this test, but that would not work with jepsen. Or it would be necessary to re-write the most control part of it. So, probably not this time. This comment was more about using the fresh built, not packaged binaries for the test. That's done in one of my follow-up patches. PS1, Line 54: > whitespace Done http://gerrit.cloudera.org:8080/#/c/5492/1/java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu/register.clj: PS1, Line 30: (:table-name test) > nit: consider introducing a variable for that in this scope: it's reference That's done in https://gerrit.cloudera.org/#/c/5500/ -- To view, visit http://gerrit.cloudera.org:8080/5492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I590c6e78840304b3131666c7037ff9a08dc77dea Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
