Todd Lipcon has posted comments on this change. Change subject: path_util: Add IsRelativePathOrEmpty() helper function ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5617/1/src/kudu/util/path_util.cc File src/kudu/util/path_util.cc: Line 40: if (path.empty() || path[0] != '/') return true; > I think we've already lost the "encapsulate path separators to ease porting btw my concern isn't anything about ability to inline - more that when I'm reading some code that uses this function, I think to my self "oh, this function must be doing something interesting, I better go page it in" whereas if I just saw foo.startswith("/") I'd immediately get it without having to go look at the definition. -- To view, visit http://gerrit.cloudera.org:8080/5617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieae26e50fb299fc9227cbc2d212bce6db0c11571 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
