Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5620/1//COMMIT_MSG Commit Message: Line 28: because breakpad does not properly namespace its includes (however it > I'm pro-hack here because I think the possibility for include conflicts is Done http://gerrit.cloudera.org:8080/#/c/5620/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: Line 208: breakpad_client > Not sure. I will check. AFAIK it doesn't make it into the client library. I got empty output from running this command in release mode: nm -a lib/exported/libkudu_client.so | egrep "breakpad|Minidump" http://gerrit.cloudera.org:8080/#/c/5620/1/src/kudu/util/minidump.cc File src/kudu/util/minidump.cc: PS1, Line 220: CreateDirsRecursively > right, but for other paths (log dir, data dirs, etc) we don't recursively c Although I don't think it's a huge risk I can see the argument. Removed. -- To view, visit http://gerrit.cloudera.org:8080/5620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I495695cc38b75377f20b0497093a81ed5baa887f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
