Dinesh Bhat has posted comments on this change. Change subject: Add Google Breakpad support to Kudu ......................................................................
Patch Set 3: (4 comments) I forgot to press send on this friday. Thinking out loud, I am trying to see what's the real advantage breakpad can give us over gdb corefile ? If we could squeeze in more info about kudu components - things like which tablet_id caused the crash - in the crash info, it might be one way of gaining control over how we want to present crash dump info in a useful manner for debugger. http://gerrit.cloudera.org:8080/#/c/5620/3//COMMIT_MSG Commit Message: Line 36: It would be good to include a section on how-to go about debugging the minidump file. For eg, which tool to use, should we rely on another tool to convert minidump to corefile and run gdb etc. http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc File src/kudu/util/minidump.cc: PS3, Line 160: Slice Do we explicitly want to include #include "kudu/util/slice.h" for this ? PS3, Line 164: Attempting to delete it Nit: would be nice to print this in next line separately. PS3, Line 221: Impala s/Impala/kudu ? -- To view, visit http://gerrit.cloudera.org:8080/5620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I495695cc38b75377f20b0497093a81ed5baa887f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
