Alexey Serbin has posted comments on this change. Change subject: webserver: improve SSL certificate handling ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5015/5/src/kudu/server/webserver_options.cc File src/kudu/server/webserver_options.cc: PS5, Line 56: .PEM > hrm.. isn't it a file extension? I might miss something, but the sentence meaning seems to be '... certificate file, in some format.' So, I thought PEM in this context is about format of the data stored in the file, not about the extension. It's just a nit, feel free to ignore. -- To view, visit http://gerrit.cloudera.org:8080/5015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b508cebbe6f31556e6d5a5fba5e5e9fb44cf1b9 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
