Dan Burkert has posted comments on this change. Change subject: webserver: improve SSL certificate handling ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5015/7/src/kudu/rpc/rpc-test-base.h File src/kudu/rpc/rpc-test-base.h: Line 423: CHECK_OK(CreateSSLServerCert(server_cert_path)); > yea, will worry about that when working on these TODOs, right? ie this is j I meant I'd moved CreateSSLServerCert from rpc/ to security/ because I needed it in a security test. If the long term solution is to use security/test/test_cert.h and remove security/security-test-util.h, that sounds good to me. -- To view, visit http://gerrit.cloudera.org:8080/5015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b508cebbe6f31556e6d5a5fba5e5e9fb44cf1b9 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
