Adar Dembo has posted comments on this change. Change subject: KUDU-1422 [java client] modifiable error collector capacity ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5291/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: Line 213: * Sets the maximum capacity of this session's ErrorCollector. > My thinking is that you'd actually want to specify the number of errors you I can see the argument for both size-based and count-based capacity. We used sized-based capacity in the C++ client at the request of Impala, who wanted to upper bound the memory consumption of a particular query against Kudu. Writ large, I think size-based capacity makes sense when the user of the client is an application. On the other hand, as Eric points out, count-based capacity can be useful when the user of the client is a user who expects to interact directly with errors rather than adapting them into something else. Another option is to implement both approaches and consider either bound when collecting a new error. What do you guys think? -- To view, visit http://gerrit.cloudera.org:8080/5291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae382050eb5eaf9c169dd3ef7ed4dbf5b5f1c334 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: eric-maynard <emayn...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: eric-maynard <emayn...@cloudera.com> Gerrit-HasComments: Yes
