David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-1836. Enable compression of DeltaFiles
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5737/1//COMMIT_MSG
Commit Message:

PS1, Line 10: eems to do a decent job of
            : compression in real-life scenarios.
care to add some numbers in the scenarios you've seen?


http://gerrit.cloudera.org:8080/#/c/5737/1/src/kudu/tablet/deltafile.cc
File src/kudu/tablet/deltafile.cc:

PS1, Line 47: default
> Just curious: why is 'default' in the name?  Does it mean there is another 
ditto on alexey's comment


-- 
To view, visit http://gerrit.cloudera.org:8080/5737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I754b31c63ef6c5d7b4ffbcbb0ad8982f9978ca83
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to