Todd Lipcon has posted comments on this change.

Change subject: KUDU-1836. Enable compression of DeltaFiles
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5737/1//COMMIT_MSG
Commit Message:

PS1, Line 10: eems to do a decent job of
            : compression in real-life scenarios.
> care to add some numbers in the scenarios you've seen?
yea, it's a bit hard to get these numbers because we dont ahve an easy way to 
extract a standalone deltafile from a tablet, but I'll try to figure out a way 
(perhaps build a kudu tool to extract a block from an FS)


http://gerrit.cloudera.org:8080/#/c/5737/1/src/kudu/tablet/deltafile.cc
File src/kudu/tablet/deltafile.cc:

PS1, Line 47: default
> ditto on alexey's comment
yea, paving the way for eventually allowing this to be set as a table property. 
This would be the default when the table property is not specified. (and I 
don't want to have to change the flag name later)


-- 
To view, visit http://gerrit.cloudera.org:8080/5737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I754b31c63ef6c5d7b4ffbcbb0ad8982f9978ca83
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to