Adar Dembo has posted comments on this change. Change subject: thirdparty: patch glog for better breakpad support ......................................................................
Patch Set 2: > > Still trying to wrap my head around who among breakpad and glog is > > responsible for which signals... > > The way I implemented it in the following patch, the minidump > signal handler is called first and the glog signal handler is > called second. Right, but for which signals? Just SIGABRT? AFAICT, glog handles SIGSEGV, SIGILL, SIGFPE, SIGABRT, SIGBUS, and SIGTERM. -- To view, visit http://gerrit.cloudera.org:8080/5742 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b5649fcd11dd083e6a64bf9ba088437ff49b8f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: No
