Mike Percy has posted comments on this change.

Change subject: thirdparty: patch glog for better breakpad support
......................................................................


Patch Set 2:

> Right, but for which signals? Just SIGABRT? AFAICT, glog handles
 > SIGSEGV, SIGILL, SIGFPE, SIGABRT, SIGBUS, and SIGTERM.

Good question. I wrote a test to verify this as part of the breakpad patch. 
Minidumps are produced for all of the above, except SIGTERM (by design, since 
SIGTERM is for graceful shutdown).

Stack traces are produced for all of the above signals.

-- 
To view, visit http://gerrit.cloudera.org:8080/5742
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86b5649fcd11dd083e6a64bf9ba088437ff49b8f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-HasComments: No

Reply via email to