Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5620/3/src/kudu/util/minidump.cc File src/kudu/util/minidump.cc: Line 118: minidump_exception_handler->WriteMinidump(FLAGS_minidump_path, DumpCallback, nullptr); > My initial read was that "compromised context" meant "in a signal handler, Hrmm. I was interpreting it the other way, but I think you're right... this would not be async-signal safe. For now what I'll do is remove the SIGUSR1 functionality, and file a JIRA against Impala for doing the same thing. The right way to do it would probably be to have a signal-handling thread. For the moment I'm going to post an update to this patch including this functionality, just to get a test run, but I'll follow up with another version after that. -- To view, visit http://gerrit.cloudera.org:8080/5620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I495695cc38b75377f20b0497093a81ed5baa887f Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
