Alexey Serbin has posted comments on this change.

Change subject: [kudu-jepsen] added Jenkins script
......................................................................


Patch Set 6:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5624/6//COMMIT_MSG
Commit Message:

PS6, Line 12:  
> nit: extra space
Done


PS6, Line 13: and the freshly built
            : Kudu Java client there.
> should mention that the test clients run there too, not just the control lo
Done


PS6, Line 21: The Kudu cluster should consist of Linux machines of the same
            :      architecture and OS distro as the Jenkins slave
> aren't the jenkins slaves running centos or something? I though the jepsen 
As I understand, in general Jenkins slaves can run any Unix-like OS which 
supports Jenkins agent (JVM-based thing).  In this context, this restriction, 
combined with restriction 2, turns into requirement to have Debian Linux distro 
with the same ABI for both Jenkins slave and Jepsen DB nodes.

I did not expect this to be confusing, but if you could propose less confusing 
and better phrasing for this, I would appreciate it.


http://gerrit.cloudera.org:8080/#/c/5624/6/src/kudu/scripts/jepsen.sh
File src/kudu/scripts/jepsen.sh:

PS6, Line 63: release
> this should accept an override. actually not sure if we shouldn't be using 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36a7e890baabb5427b22daa3aeee58ed894b83d6
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to