Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ......................................................................
Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/c/5760/4/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: Line 29: #include <gflags/gflags.h> > warning: #includes are not sorted properly [llvm-include-order] Done Line 72: remote_(std::move(remote)), > warning: std::move of the variable of a trivially-copyable type has no effe Done http://gerrit.cloudera.org:8080/#/c/5760/4/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: Line 58: using std::shared_ptr; > warning: using decl 'shared_ptr' is unused [misc-unused-using-decls] Done Line 59: using std::unique_ptr; > warning: using decl 'unique_ptr' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/5760/4/src/kudu/rpc/reactor.cc File src/kudu/rpc/reactor.cc: Line 599: void Abort(const Status &status) override { > warning: parameter 'status' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/5760/4/src/kudu/rpc/sasl_helper.cc File src/kudu/rpc/sasl_helper.cc: Line 42: using std::set; > warning: using decl 'set' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/5760/4/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: Line 23: #include <set> > warning: #includes are not sorted properly [llvm-include-order] Done Line 264: // TODO: Support security flags. > warning: missing username/bug in TODO [google-readability-todo] Done Line 418: } else if (s.IsIncomplete()) { > warning: don't use else after return [readability-else-after-return] Done -- To view, visit http://gerrit.cloudera.org:8080/5760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I567b62f3341a1e74342c30c76b63f2ca5d7990bd Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
