Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [6/n]: Refactor RPC negotiation ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/5760/7/src/kudu/rpc/reactor.cc File src/kudu/rpc/reactor.cc: Line 464: when_(std::move(when)), > warning: std::move of the variable of a trivially-copyable type has no effe Done Line 553: virtual void Run(ReactorThread* reactor) OVERRIDE { > warning: parameter 'reactor' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/5760/7/src/kudu/rpc/reactor.h File src/kudu/rpc/reactor.h: Line 97: virtual void Run(ReactorThread* reactor) OVERRIDE; > warning: function 'kudu::rpc::DelayedTask::Run' has a definition with diffe Done -- To view, visit http://gerrit.cloudera.org:8080/5760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I567b62f3341a1e74342c30c76b63f2ca5d7990bd Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
