Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1835 (part 1). Move compression codec classes to util ......................................................................
KUDU-1835 (part 1). Move compression codec classes to util This creates a new library util_compression which has the compression codec implementations. Previously, these were in cfile, but we don't want to add a dependency from consensus onto cfile (that's a messy coupling). The reason to add this as a new module instead of just directly to util/ is that it brings in more third-party dependencies, and we've identified that we'd like to try to slim down 'util' over time to make it easier for other projects (eg Impala) to consume it piecemeal. The other change here is that I had to move the CompressionType enum from common.proto into a new proto module -- again to avoid an unwanted dependency from util onto common. The existing compression-test was half related to testing CFile compression, and half a direct test of the codec implementations. As such, the codec test was moved to the new module, and the cfile-related test was moved into cfile-test.cc. As I did so, I realized that much of the test content was redundant, so removed the redundant cases. Change-Id: Iffe09aba18fd829f5918aabe061ca8b7f9d494c0 Reviewed-on: http://gerrit.cloudera.org:8080/5735 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java M src/kudu/cfile/CMakeLists.txt M src/kudu/cfile/block_compression.cc M src/kudu/cfile/block_compression.h M src/kudu/cfile/cfile-test-base.h M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile.proto M src/kudu/cfile/cfile_reader.cc M src/kudu/cfile/cfile_writer.cc D src/kudu/cfile/compression-test.cc M src/kudu/common/CMakeLists.txt M src/kudu/common/common.proto M src/kudu/util/CMakeLists.txt A src/kudu/util/compression/compression-test.cc A src/kudu/util/compression/compression.proto R src/kudu/util/compression/compression_codec.cc R src/kudu/util/compression/compression_codec.h 17 files changed, 201 insertions(+), 177 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffe09aba18fd829f5918aabe061ca8b7f9d494c0 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
