Alexey Serbin has submitted this change and it was merged. Change subject: Use Traits to avoid duplicate code in SSL wrappers ......................................................................
Use Traits to avoid duplicate code in SSL wrappers cert_management.cc contained some duplicate code for each of the wrappers. In addition, having to always remember the correct 'free' function for each SSL type was a bit difficult. This uses a "traits" pattern to try to clean up the code. It doesn't save a ton of lines of code, but it replaces a lot of imperative code with more "declarative" lists of types and functions. Change-Id: If1c44857358fc82f2694dff021b9f2ac3641313a Reviewed-on: http://gerrit.cloudera.org:8080/5767 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> Reviewed-by: Dan Burkert <[email protected]> --- M src/kudu/security/ca/cert_management.cc 1 file changed, 123 insertions(+), 136 deletions(-) Approvals: Dan Burkert: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5767 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1c44857358fc82f2694dff021b9f2ac3641313a Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
