Todd Lipcon has posted comments on this change. Change subject: Use Traits to avoid duplicate code in SSL wrappers ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5767/3/src/kudu/security/ca/cert_management.cc File src/kudu/security/ca/cert_management.cc: PS3, Line 83: free > I meant just have it instead of XXX_new() functions, make_ssl_new() would n hrm. yea I'm inclined to leave it for now. PS3, Line 135: switch (format) { : case DataFormat::DER: : CERT_RET_NOT_OK(Traits::write_der(bio, obj), "error exporting DER format"); : break; : case DataFormat::PEM: : CERT_RET_NOT_OK(Traits::write_pem(bio, obj), "error exporting PEM format"); : break; : } > ok, this sounds reasonable. Is there a flag to enable those warnings? -Wa hrm really? I've seen my clang 3.9 issue warnings. you tried removing one of the cases and it didn't warn? -- To view, visit http://gerrit.cloudera.org:8080/5767 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1c44857358fc82f2694dff021b9f2ac3641313a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
