Adar Dembo has posted comments on this change. Change subject: Add Google Breakpad support to Kudu ......................................................................
Patch Set 24: Code-Review+2 Looks good. The test failure in client_symbol-test.sh is likely because we need to hide the breakpad symbols; see src/kudu/client/symbols.map. I don't know under what circumstances symbols in util/ wind up in the client vs. not; in this case, I don't see any reason why the client would link these symbols. But if we hide them, it doesn't really matter. The only effect is that the client library gets a little larger. -- To view, visit http://gerrit.cloudera.org:8080/5620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I495695cc38b75377f20b0497093a81ed5baa887f Gerrit-PatchSet: 24 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
