Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu ......................................................................
Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/5620/21/src/kudu/util/minidump-test.cc File src/kudu/util/minidump-test.cc: PS21, Line 85: #if defined(ADDRESS_SANITIZER) : // CHECK raises a SIGSEGV under ASAN and fails this test. : return; : #endif > I have investigated this a bit and so far I'm not quite sure why it's gener I finally figured this out. The failure function must not be nullptr and must call abort(). http://gerrit.cloudera.org:8080/#/c/5620/21/src/kudu/util/minidump.cc File src/kudu/util/minidump.cc: PS21, Line 261: // Send SIGUSR1 signal to thread, which will wake it up. : kill(getpid(), SIGUSR1); > > Incidentally, a blocked SIGUSR1 will be inherited by all Kudu subprocesse Done -- To view, visit http://gerrit.cloudera.org:8080/5620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I495695cc38b75377f20b0497093a81ed5baa887f Gerrit-PatchSet: 21 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
