Dan Burkert has posted comments on this change. Change subject: TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes ......................................................................
Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/5761/10/src/kudu/rpc/rpc-test-base.h File src/kudu/rpc/rpc-test-base.h: Line 318: const char *GenericCalculatorService::kSecondString = > warning: variable 'kSecondString' defined in a header file; variable defini ignoring... http://gerrit.cloudera.org:8080/#/c/5761/8/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: Line 110: if (!handshake->ssl_) { > warning: redundant get() call on smart pointer [google-readability-redundan Done http://gerrit.cloudera.org:8080/#/c/5761/7/src/kudu/security/tls_handshake.cc File src/kudu/security/tls_handshake.cc: Line 20: #include <memory> > warning: #includes are not sorted properly [llvm-include-order] Done Line 76: > warning: don't use else after return [readability-else-after-return] Done Line 116: return Status::OK(); > warning: don't use else after return [readability-else-after-return] Done -- To view, visit http://gerrit.cloudera.org:8080/5761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6776dbdc488eee56f7273cdd8bcd2b2b8c1ffa04 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
