Todd Lipcon has posted comments on this change. Change subject: TLS-negotiation [7/n]: Add TLS helper classes for handling tunneled TLS handshakes ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/5761/10/src/kudu/security/CMakeLists.txt File src/kudu/security/CMakeLists.txt: PS10, Line 73: tls_handshake-test > nit: why not to put it under the test sub-dir? oh, I meant to point this out to you -- the idea of the 'test' module and corresponding dir is that those are test infrastructure that are usable by other modules, etc, rather than saying that we'll put all unit tests into the test/ dir. (I found it hard to find the cert management test from my editor the other day because it was in test/) -- To view, visit http://gerrit.cloudera.org:8080/5761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6776dbdc488eee56f7273cdd8bcd2b2b8c1ffa04 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
