Adar Dembo has posted comments on this change. Change subject: WIP: Support for enabling webserver SSL in CSD ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5806/1/java/kudu-csd/src/descriptor/service.sdl File java/kudu-csd/src/descriptor/service.sdl: Line 174: "sslServer": { If I'm understanding this correctly, this generates ssl_enabled, webserver_private_key_file, webserver_certificate_file, and webserver_private_key_password_cmd parameters. All but the first are included in the gflagfile. I presume this also affects the "externalLink" section, such that https:// links are generated? BTW, one piece of feedback we've received in the past is to unify master/tserver params under the service itself where possible. Can we do that for sslServer? Or must it be defined at the role level? If the latter, we may need to namespace the parameters with "master_" or "tserver_" prefixes to avoid collisions; I'm not 100% sure. -- To view, visit http://gerrit.cloudera.org:8080/5806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88cde67883f067b29055aa6df22d2c24c7dfe6fa Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
