Adar Dembo has posted comments on this change.

Change subject: WIP: Support for enabling webserver SSL in CSD
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5806/1/java/kudu-csd/src/descriptor/service.sdl
File java/kudu-csd/src/descriptor/service.sdl:

Line 174:       "sslServer": {
> If I'm understanding this correctly, this generates ssl_enabled, webserver_
A few quick follow-ups:

- We can't unify these; they must be per-role.
- We don't need to add master_/tserver_ prefixes, as these aren't the 
in-database parameter names; they're just the emitted config names.


-- 
To view, visit http://gerrit.cloudera.org:8080/5806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88cde67883f067b29055aa6df22d2c24c7dfe6fa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to