David Ribeiro Alves has posted comments on this change. Change subject: [timestamp] Build and and add boost's date_time lib ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5818/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 609: build_boost_libs() { > You need to make a few changes here so that it conforms to the rest of the k, I'll try to pass the flads to ./b2, thanks for the pointers. I'll try to make this work on my env first as to not mess the jenkins slaves. Line 613: ./b2 cflags="-DBOOST_DATE_TIME_POSIX_TIME_STD_CONFIG" > Wait, so we need to provide this cflag when building boost AND when consumi so that the iddef is triggered in the headers and we're able to use the nanosecond resolution methods Line 614: cp stage/lib/* $PREFIX/lib > Can't we do a "make install" or equivalent to install the headers along wit what mike said, we're already "installing" the headers on our own so we only need to copy the .a and .so files. -- To view, visit http://gerrit.cloudera.org:8080/5818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I277c4fda15575e271c426735552762884cb28c43 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
