Adar Dembo has posted comments on this change. Change subject: [timestamp] Build and and add boost's date_time lib ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5818/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 614: cp stage/lib/* $PREFIX/lib > what mike said, we're already "installing" the headers on our own so we onl But, we shouldn't be installing the headers on their own (see my other comments to that effect). That was only necessary when we explicitly did not want any libraries. Some background: when I wrote the header installation code I tried to find the right invocation of b2 that'd install just the headers but couldn't, so I ended up using rsync. If we're going to install both headers and libraries, we should do it in one fell swoop with "b2 install", just as we use "make install" for nearly every other installed package. -- To view, visit http://gerrit.cloudera.org:8080/5818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I277c4fda15575e271c426735552762884cb28c43 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
