Adar Dembo has posted comments on this change. Change subject: thirdparty: Clean up thirdparty prefix from previous builds ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5826/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: Line 54: if [ "$#" = "0" ]; then I don't think this is as helpful as it can be, because it's actually pretty rare to end up in this section. Most people invoke build-if-necessary.sh, which will run "build-thirdparty.sh common uninstrumented" and end up in L62. I agree though that deleting the prefix directories is the wrong move if an explicit dependency was requested (i.e. not a dependency "group"). How about this: 1. Change L103 so that the list of prefix directories to deal with is determined by F_COMMON, F_UNINSTRUMENTED, and F_TSAN (i.e. if F_COMMON == 1, add PREFIX_COMMON to the list, etc.). 2. Unconditionally rm -rf and mkdir -p the prefix directory as you iterate on it. So it'd look something like this: PREFIX_DIRS= if $F_COMMON: PREFIX_DIRS += $PREFIX_COMMON if $F_UNINSTRUMENTED: PREFIX_DIRS += $PREFIX_DEPS if $F_TSAN: PREFIX_DIRS += $PREFIX_TSAN for PREFIX_DIR in PREFIX_DIRS: rm -rf $PREFIX_DIR mkdir -p $PREFIX_DIR mkdir -p $PREFIX_DIR/lib ... Line 447: $TP_DIR/postflight.py The TSAN check run in postflight.py should probably be restricted to when F_TSAN=1. -- To view, visit http://gerrit.cloudera.org:8080/5826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2a7ceb3dad1acede152775611f549798723016c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
