Adar Dembo has posted comments on this change. Change subject: thirdparty: Clean up thirdparty prefix from previous builds ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5826/2/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: Line 105: local INIT_FLAG="" I think the flag passing mechanism is unnecessarily generic for the very limited case we need here. How about something like this: init_prefix $PREFIX_COMMON init_prefix $PREFIX_UNINSTRUMENTED libdir init_prefix $PREFIX_TSAN libdir Then in init_prefix(): local PREFIX_DIR=$1 local MAKE_LIBDIR=$2 <do stuff that applies to every case> if [[ -n $MAKE_LIBDIR ]]; then mkdir -p $PREFIX_DIR/lib fi If/when we need a more sophisticated arg passing mechanism in the future, we can add it. http://gerrit.cloudera.org:8080/#/c/5826/2/thirdparty/postflight.py File thirdparty/postflight.py: PS2, Line 21: Currently, the only check is a tsan-related check. It is only executed when the : string "tsan" is passed as an argument when executing this script. Why add this level of specificity? It'll become stale and require an update the very next time a check is added. -- To view, visit http://gerrit.cloudera.org:8080/5826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2a7ceb3dad1acede152775611f549798723016c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
