Dan Burkert has posted comments on this change. Change subject: [security] sign/verify data using RSA key pair ......................................................................
Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/5805/13//COMMIT_MSG Commit Message: PS13, Line 11: SHA1 Looks like maybe SHA1 was removed in later iterations? http://gerrit.cloudera.org:8080/#/c/5805/13/src/kudu/security/crypto.cc File src/kudu/security/crypto.cc: Line 93: default: Wasn't the consensus to remove the default case? -- To view, visit http://gerrit.cloudera.org:8080/5805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fa04bb7d09aa416363998e2f8d7ccbdea625e4f Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes