Todd Lipcon has posted comments on this change. Change subject: [security] sign/verify data using RSA key pair ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5805/2/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: PS2, Line 436: default: : CHECK(false) << "unsupported digest operation"; > Sure, but it's two extra lines of code, and we only get the runtime error i btw http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations has some interesting bits on this. -- To view, visit http://gerrit.cloudera.org:8080/5805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fa04bb7d09aa416363998e2f8d7ccbdea625e4f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
