Adar Dembo has posted comments on this change.

Change subject: thirdparty: patch cmake to avoid select() when reading from 
subprocess pipes
......................................................................


Patch Set 1:

> This should only affect the cmake build itself, i.e. thirdparty.

Just to clarify, some developers like to use cmake from thirdparty to build 
Kudu itself, not just to build thirdparty cmake-based components. I normally 
use my system's cmake so this wouldn't affect me, but it'd affect anyone 
building on el6, where the system's cmake is just too old to be used for Kudu 
builds.

-- 
To view, visit http://gerrit.cloudera.org:8080/5857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33596a36c1f974078140360cb62b01f58211b44c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: No

Reply via email to